Weekly Project Management Digest #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
9263/feature/weekly-pm-digest
branch
2 times, most recently
from
4c9d15d to
8efa8f0
Compare
jimchamp
force-pushed
the
9263/feature/weekly-pm-digest
branch
from
0bb5c00 to
18e3754
Compare
|
Here's a fabricated example with some of the changes I'd love to see (pending input from the team): 
Overview of changes
|
jimchamp
added
the
Needs: Submitter Input
|
Converting to draft until the changes have been made and pushed. |
jimchamp
force-pushed
the
9263/feature/weekly-pm-digest
branch
from
471c8b2 to
ed3ca85
Compare
github-actions
bot
removed
the
Needs: Submitter Input
- Only publish summary line items that notify Slack user if there is something actionable - Include link for issues needing leads - Replace Slack @ mention with GitHub username in assigned PR summaries - Changes staff PR summaries to one-liners (instead of two lines per PR) - `await` the completion of `main()` before printing "finishing" message to console
Changes `forStaff` to `publishFullDigest`, which better describes what is happening
jimchamp
force-pushed
the
9263/feature/weekly-pm-digest
branch
from
c2703c9 to
f976af6
Compare
for more information, see https://pre-commit.ci
jimchamp
commented
May 22, 2024
| * @param {Array<Lead>} | ||
| * @returns {Promise<Array<string>>} Messages about untriaged issues | ||
| */ | ||
| async function prepareUntriagedIssues(leads) { |
There was a problem hiding this comment.
These async prepare* functions can be improved by passing the issues as a parameter. Then, they would no longer need to be async, and would only have concern themselves with preparing sections of the Slack message.
If a reviewer agrees, I'll go ahead and push that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9263
Creates new
weekly_status_report.mjsscript and corresponding GitHub workflow. Adds two configuration files for the new script: one for a more comprehensive digest that will be published in#team-abc-plus, and another for a lighter digest that will be published in#openlibrary-leads-g.Both digests are scheduled to run at the same time. The workflow can easily be configured to prepare and publish each digest at different times, if needed (example can be found here)
Technical
The new workflow caches the
@octokit/actionlibrary, without overwriting the cache entry for ourjavascript_testsworkflow. A similar pattern can be used in the other workflow that has anoctokitdependency (see #9250)Testing
Screenshot
Stakeholders